Feature: [Linkgraph] Prioritize faster routes for passengers and express cargo #9457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordAro
reviewed
Aug 16, 2021
nchappe
force-pushed
the
cargodist-travel-time
branch
from
27a891e
to
4d1b978
Compare
|
Thanks for the comments. There were indeed some typing inconsistencies with travel times, now they are all uint32. As for |
michicc
reviewed
Aug 16, 2021
nchappe
force-pushed
the
cargodist-travel-time
branch
from
4d1b978
to
116f093
Compare
…d express cargo Passengers usually prefer fast paths to short paths. Average travel times of links are updated in real-time for use in Dijkstra's algorithm, and newer travel times weigh more, just like capacities.
nchappe
force-pushed
the
cargodist-travel-time
branch
from
116f093
to
8600b49
Compare
michicc
approved these changes
Aug 17, 2021
There was a problem hiding this comment.
My mini test-game confirms that it works in some way (😄), and I like the behaviour more.
Test setup: A slow direct bus route compared to a longer but faster train route with one intermediate change. Unmodified, pax are perpetually waiting for full buses while with this PR, the trains carry the main load.
Somebody will cry wolf that there carefully timed network is completely disrupted, of course.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Cargodist does not optimize for travel time but for distance, which means passengers sometimes take (for instance) a slow but short bus route instead of a faster train route to their destination. I think it would be more intuitive if cargodist prioritized the fastest paths, at least for passengers and express cargo (goods, food). Since cargo payment depends on travel time, this may also increase income for some networks.
Description
This PR adds a member variable
travel_time_sumtoLinkGraph::Edge. When a vehicle traverses a link, the product of its travel time and its capacity is added to this variable, so thattravel_time_sum / capacitygives the average travel time of a cargo unit traversing this edge in a saturated network. Just like capacities, the value is halved every 256 days, so that older travel times weigh less in the average.This average travel time is then used in the MCF solver in place of the distance for cargo of classes
CC_PASSENGERSandCC_EXPRESS.Limitations
This change could be hidden behind a default-disabled setting for better backward compatibility.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.