You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Game compiles when RANDOM_DEBUG or ENABLE_NETWORK_SYNC_EVERY_FRAME are defined.
RANDOM_DEBUG is mentioned in COMPILING.md so could be considered non-internal.
Actual result
struct Packet has had many things done to it but the use guarded by ENABLE_NETWORK_SYNC_EVERY_FRAME has not been updated.
/home/jgr/openttd/trunk/src/network/network_client.cpp: In member function ‘virtual NetworkRecvStatus ClientNetworkGameSocketHandler::Receive_SERVER_FRAME(Packet*)’:
/home/jgr/openttd/trunk/src/network/network_client.cpp:861:9: error: ‘PacketSize Packet::pos’ is private within this context
861 | if (p->pos + 1 < p->size) {
| ^~~
In file included from /home/jgr/openttd/trunk/src/network/core/tcp.h:16,
from /home/jgr/openttd/trunk/src/network/core/tcp_coordinator.h:16,
from /home/jgr/openttd/trunk/src/network/network_internal.h:14,
from /home/jgr/openttd/trunk/src/network/network_client.h:13,
from /home/jgr/openttd/trunk/src/network/network_client.cpp:28:
/home/jgr/openttd/trunk/src/network/core/packet.h:49:13: note: declared private here
49 | PacketSize pos;
| ^~~
/home/jgr/openttd/trunk/src/network/network_client.cpp:861:22: error: ‘struct Packet’ has no member named ‘size’; did you mean ‘Size’?
861 | if (p->pos + 1 < p->size) {
| ^~~~
| Size
Steps to reproduce
Compile with CXXFLAGS="-DRANDOM_DEBUG" cmake ..
The text was updated successfully, but these errors were encountered:
JGRennison
added a commit
to JGRennison/OpenTTD-patches
that referenced
this issue
Oct 18, 2021
Version of OpenTTD
master
Expected result
Game compiles when RANDOM_DEBUG or ENABLE_NETWORK_SYNC_EVERY_FRAME are defined.
RANDOM_DEBUG is mentioned in COMPILING.md so could be considered non-internal.
Actual result
struct Packet has had many things done to it but the use guarded by ENABLE_NETWORK_SYNC_EVERY_FRAME has not been updated.
Steps to reproduce
Compile with
CXXFLAGS="-DRANDOM_DEBUG" cmake ..
The text was updated successfully, but these errors were encountered: