Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A test to produce a pre-Ζήνων trajectory #3159

Merged
merged 4 commits into from
Oct 20, 2021

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Oct 19, 2021

Based on a save given by @lpgagnon.

For use with #3136.

// TODO(phl): Check that we mention a compatibility path here once something
// changes.
EXPECT_THAT(log_warning.string(),
Not(HasSubstr("pre-Haar")));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This expectation doesn’t mean much, since the relevant path doesn’t log.
Please rename the identifier therein and add a log.

bool const is_pre_grotendieck_haar = message.has_start_of_dense_timeline();
Downsampling downsampling({message.max_dense_intervals(),
Length::ReadFromMessage(message.tolerance())});
if (is_pre_grotendieck_haar) {
// No support for forks in legacy saves, so |find| will succeed and ++ is
// safe.
auto it = timeline.find(
Instant::ReadFromMessage(message.start_of_dense_timeline()));
CHECK(it != timeline.end());
for (; it != timeline.end(); ++it) {
downsampling.Append(it);
}
} else {

Update ll. 290 sq. of this file accordingly.
// TODO(phl): Check that we mention a compatibility path here once something
// changes.
EXPECT_THAT(log_warning.string(),
Not(HasSubstr("pre-Gröbner")));

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had added that very same trace in a different branch :-/ And now that it's present, it's firing on the Butcher test.

@eggrobin eggrobin added the LGTM label Oct 19, 2021
@pleroy pleroy merged commit 8841754 into mockingbirdnest:master Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants