Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Crash]: Main Menu #9630

Closed
ghost opened this issue Oct 20, 2021 · 5 comments
Closed

[Crash]: Main Menu #9630

ghost opened this issue Oct 20, 2021 · 5 comments

Comments

@ghost
Copy link

ghost commented Oct 20, 2021

Version of OpenTTD

12.0 , Win 10

Steps to reproduce

I changed some setting and the game crashed, now the game crash on the main menu.
crash.log
crash

Upload crash files

OpenTTD Crash 12.zip
@James103
Copy link
Contributor

Can you please try the following?

  1. Download OpenTTD 1.12 or a nightly of OpenTTD as a zip file from openttd.org (not Steam).
  2. Extract the zip file into an empty directory in your Documents folder.
  3. Start the program cmd.exe.
  4. Inside the command prompt, navigate to the directory where you installed the standalone/portable version of OpenTTD, and run openttd -v win32.

@glx22
Copy link
Contributor

glx22 commented Oct 20, 2021 •
edited 

>	openttd.exe!Blitter_40bppAnim::Draw<0>(const Blitter::BlitterParams * bp, ZoomLevel zoom) Ligne 279	C++
 	openttd.exe!Blitter_40bppAnim::Draw(Blitter::BlitterParams * bp, BlitterMode mode, ZoomLevel zoom) Ligne 324	C++
 	openttd.exe!GfxBlitter<4,0>(const Sprite * const sprite, int x, int y, BlitterMode mode, const SubSprite * const sub, unsigned int sprite_id, ZoomLevel zoom, const DrawPixelInfo *) Ligne 1187	C++
 	openttd.exe!GfxMainBlitterViewport(const Sprite * sprite, int x, int y, BlitterMode mode, const SubSprite * sub, unsigned int sprite_id) Ligne 1233	C++
 	openttd.exe!DrawSpriteViewport(unsigned int img, unsigned int pal, int x, int y, const SubSprite * sub) Ligne 1030	C++
 	openttd.exe!ViewportDrawTileSprites(const std::vector<TileSpriteToDraw,std::allocator<TileSpriteToDraw>> * tstdv) Ligne 1496	C++
 	openttd.exe!ViewportDoDraw(const Viewport * vp, int left, int top, int right, int bottom) Ligne 1749	C++
 	[Cadre en ligne] openttd.exe!ViewportDraw(const Viewport * vp, int) Ligne 1803	C++
 	openttd.exe!Window::DrawViewport() Ligne 1823	C++
 	openttd.exe!NWidgetViewport::Draw(const Window * w) Ligne 2055	C++
 	openttd.exe!NWidgetPIPContainer::Draw(const Window * w) Ligne 1236	C++
 	openttd.exe!Window::DrawWidgets() Ligne 640	C++
 	openttd.exe!MainWindow::OnPaint() Ligne 248	C++
 	openttd.exe!DrawOverlappedWindow(Window * w, int left, int top, int right, int bottom) Ligne 960	C++
 	openttd.exe!DrawOverlappedWindowForAll(int left, int top, int right, int bottom) Ligne 983	C++
 	openttd.exe!RedrawScreenRect(int left, int top, int right, int bottom) Ligne 1589	C++
 	openttd.exe!DoSetViewportPosition(Window::WindowIterator<0> it, int left, int top, int width, int height) Ligne 333	C++
 	openttd.exe!DoSetViewportPosition(Window::WindowIterator<0> it, int left, int top, int width, int height) Ligne 280	C++
 	openttd.exe!SetViewportPosition(Window * w, int x, int y) Ligne 387	C++
 	openttd.exe!UpdateViewportPosition(Window * w) Ligne 1899	C++
 	openttd.exe!SelectGameWindow::OnRealtimeTick(unsigned int delta_ms) Ligne 235	C++
 	openttd.exe!CallWindowRealtimeTickEvent(unsigned int delta_ms) Ligne 3050	C++
 	openttd.exe!UpdateWindows() Ligne 3073	C++
 	openttd.exe!VideoDriver::Tick() Ligne 152	C++
 	openttd.exe!VideoDriver_Win32Base::MainLoop() Ligne 868	C++
 	openttd.exe!openttd_main(int argc, char * * argv) Ligne 804	C++
 	openttd.exe!WinMain(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, char * lpCmdLine, int nCmdShow) Ligne 416	C++
 	[Code externe]

Trace is similar to #9622, just the blitter is different.

Which settings did you change ?

@ghost
Copy link
Author

ghost commented Oct 20, 2021

TTDCrash
Doesn't crash on nightly. Changed only 8 settings.

@glx22
Copy link
Contributor

glx22 commented Oct 20, 2021

I'm finally able to reproduce the crash. The important point is Maximum zoom in level.

@ghost
Copy link
Author

ghost commented Oct 20, 2021

Yes Normal crash, 2x is fine. it happen on the transition to the second background.

glx22 added a commit to glx22/OpenTTD that referenced this issue Oct 20, 2021
@glx22
Fix OpenTTD#9630, OpenTTD#9622: intro game could zoom in/out more tha…
4b06196 
…n allowed by settings
glx22 added a commit to glx22/OpenTTD that referenced this issue Oct 20, 2021
@glx22
Fix OpenTTD#9630: intro game could zoom in/out more than allowed by s…
3ed179a 
…ettings

Also fixes OpenTTD#9622
@glx22 glx22 mentioned this issue Oct 20, 2021
Closed
@glx22 glx22 closed this as completed in bc1b84c Oct 20, 2021
TrueBrain pushed a commit to TrueBrain/OpenTTD that referenced this issue Oct 23, 2021
@glx22 @TrueBrain
Fix OpenTTD#9630: intro game could zoom in/out more than allowed by s…
cdc7c1f 
…ettings (OpenTTD#9633)

Also fixes OpenTTD#9622
TrueBrain pushed a commit that referenced this issue Oct 23, 2021
@glx22 @TrueBrain
Fix #9630: intro game could zoom in/out more than allowed by settings (…
61479fd 
…#9633)

Also fixes #9622
@glx22 glx22 mentioned this issue Oct 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@glx22 @James103