Change: Don't store not to be activated newGRFs in savegames #9627
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
When a crash happens in intro menu, emergency save will contain the
newgame
grf config. But intro game can't have newgrfs, and loading the resultingcrash.sav
can cause other crashes, like any savegame with modified newgrf config.See
crash.sav
from #9622.Description
In intro menu, newgrf are only initialised and never activated, and it's indicated in the flags. So using that info it's easy to skip newgrfs from being stored in the savegame.
Of course checking
_game_mode
should work too, but I prefer the flags solution.Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.