Fix: crash with invalid version for a branch with CLIENT_INFO_LIST #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a choice to make: 1) parse as much of the version as possible 2) ignore the branch 3) ignore the request This commit goes for 3), as that is the most verbose to the developer working on OpenTTD. It is a protocol violation, and the developer should address the issue. With 1) and 2) it could remain invisible for a very long time, till it breaks. 3) is the safest, as it will be noticed sooner or later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a choice to make:
This commit goes for 3), as that is the most verbose to the developer
working on OpenTTD. It is a protocol violation, and the developer
should address the issue. With 1) and 2) it could remain invisible
for a very long time, till it breaks. 3) is the safest, as it
will be noticed sooner or later.