Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9624: compilation with RANDOM_DEBUG #9625

Merged
merged 2 commits into from
Oct 19, 2021
Merged

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented Oct 19, 2021

Motivation / Problem

Packet changed a lot 6 months ago, and some conditional code was not updated.

Description

I adapted @JGRennison's fix.
My original version was a direct conversion p->CanReadFromPacket(1) but it's better to properly check the sizes.
I also added RANDOM_DEBUG flag to dedicated build CI check as a future proof measure.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@LordAro LordAro added the backport requested This PR should be backport to current release (RC / stable) label Oct 19, 2021
@LordAro LordAro merged commit 1c0700e into OpenTTD:master Oct 19, 2021
@glx22 glx22 deleted the random_debug branch October 19, 2021 09:51
@TrueBrain TrueBrain added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants