Fix #9624: compilation with RANDOM_DEBUG #9625
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Packet
changed a lot 6 months ago, and some conditional code was not updated.Description
I adapted @JGRennison's fix.
My original version was a direct conversion
p->CanReadFromPacket(1)
but it's better to properly check the sizes.I also added
RANDOM_DEBUG
flag to dedicated build CI check as a future proof measure.Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.