New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: add setting to disable news about competitor's accidents #9638
Feature: add setting to disable news about competitor's accidents #9638
Conversation
For "arrival of first vehicle" and "production changes of industries" there are separate settings with "full"/"summary"/"off". |
Good point @frosch123 , I'll update my PR, thanks. |
To make this setting more consistent with the other settings, moved to a enum type (full, summary, off) and close to Accident / Disasters settings
To make this setting more consistent with the other settings, moved to a enum type (full, summary, off) and close to Accident / Disasters settings
…ub.com/grenoult/OpenTTD into disable_competitor_accident_news_patch
Closing this branch. A new PR has been created with correct commit messages: #9653 |
(For future reference, you can fix this with rebasing without having to open a new PR/make a new branch) |
Motivation / Problem
During a game of OpenTTD with many competitors, we can receive a lot of news regarding competitors vehicles involved in accidents. This is especially true when vehicles have low reliability and are rarely replaced:
This PR addresses the issue of receiving too many news regarding competitors vehicle crash where it doesn't bring any value or meaning to the main player. As a OpenTTD player, I want to know when my vehicles are involved in a crash but I may choose to not receive notification if competitors vehicles are destroyed.
Description
A new setting has been added "Accidents of competitor's vehicles". It's "Full" by default. When turned off, no news will be generated when a competitor vehicle is involved in a crash. When it's "Summary", only the short version will be displayed at the bottom of the screen.
A crash, in the context of this PR, is when a road vehicle is hit by a train or when an airplane misses landing at an airport.
Full: A news item is generated when setting is Full (by default) and a competitor vehicle is crashed (in this example, a plane crash):
Summary: Short news are generated when setting is "Summary" and a competitor vehicle (red) is crashed by a train:
Off: no news are generated when a competitor vehicle is crashed when settings is "Off"
Limitations
Checklist for review