Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: The previously selected signal is not saved between games #9631

Closed
Rau117 opened this issue Oct 20, 2021 · 13 comments · Fixed by #9792
Closed

[Bug]: The previously selected signal is not saved between games #9631

Rau117 opened this issue Oct 20, 2021 · 13 comments · Fixed by #9792

Comments

@Rau117
Copy link

Rau117 commented Oct 20, 2021

Version of OpenTTD

12.0 Windows

Not sure if this is intended as part of hiding advanced™ signals.
In previous versions last used signal (block/path/one-way path) was saved through games as different parameter.

It is was very convenient to have a two-way (PBS without red plate) path signal by default and select the rest via ctrl+click.

Expected result

On the new game will be choosen previously used signal

Actual result

One-way path signal is choosed by default after game loaded/reconnected to server
It does not matter if block signals are hidden or not.

Steps to reproduce

  1. Load the game and pick signal building tool
  2. Choose any signal except one-way PBS
  3. Once again load the game and pick signal tool
  4. You will get one-way PBS choosed by default and cannot change it in any way
    2021-10-20 07-38-36
@iTKerry
Copy link

iTKerry commented Oct 20, 2021

Thats annoying. Please, fix that.

@2TallTyler
Copy link
Member

Prior to #8688, there was a setting for choosing the default signal type when starting a new game, after which the GUI keeps the last-used signal selected. It did not remember the last-used signal between games.

This setting was removed in #8688 as part of a general simplification of signal-related settings, and now it defaults to one-way PBS when starting a game, then remembers the last-used signal as before.

@Rau117

This comment has been minimized.

@Rau117

This comment was marked as abuse.

@same-f
Copy link

same-f commented Oct 20, 2021

I As an admin server on which both advanced players and new players play, I can say that after the update, everything (including new ones) is in misunderstanding of the changes, and in search of signals. So far, I have seen the exact opposite of simplifying the game for beginners, as I see these beginners looking for help to turn on. And I don't understand why a handful of clever people solves what most people need by covering up their desires and whims with beginners.

@LEB0VSKI

This comment has been minimized.

@LordAro

This comment has been minimized.

@LEB0VSKI

This comment has been minimized.

@LordAro

This comment has been minimized.

@Eddi-z

This comment has been minimized.

@TrueBrain
Copy link
Member

It does not remember, It cannot remember. I searched thorugh the code. You just removed the setting that does it. In some function instead of "look in config and choose signal" it makes "always select one-way PBS".

изображение

If you read the diff carefully, you see that _default_signal_type is a "read-only" settings. That is to say: it is only read by the code, and never set (with the exception of the settings menu). In yet other words: it doesn't remember your last signal type used, but you can set what the default is when opening it.
Sounds you experience Mandela Effect :) If you don't believe me, try it out yourself in 1.11 or something. You will see you always start with the same signal type, no matter how you left it behind.

That said, I guess we could read the bug report as: "I want a way to set my default signal to either one-way or two-way". That was possible pre-12.0, and is no longer. I currently have no opinion on that :)

@Rau117

This comment was marked as abuse.

@LC-Zorg
Copy link

LC-Zorg commented Oct 24, 2021

It's not the same bug, but it seems the root of the problem is the same, so I'm writing here.
Removing the setting also means that when running different versions of the game, each time the selected signaling setting changes. Sometimes both settings. If someone uses different versions for some reason (e.g. playing on different servers), each time before or during the game has to correct these settings. This is discouraging... :/
Nightmare

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants