Change: Don't use special map gen for tropic #9634
Closed
+1
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Subtropic maps use different map generation than other climates (so does subarctic, but that's a different story) which makes it impossible to get mountainous terrain from generated maps. This limits the types of games which can be played, even as #8891 makes it possible to have all-rainforest maps. Want a hilly rainforest? Your only option is to use a heightmap.
Eliminating the special subtropic rules has been proposed before in #7340 and an associated forum topic, but was closed by the stale bot. Now that landscape generation has been simplified in #8891, I think it's worth revisiting.
Description
TGP uses separate rules for subtropic and subarctic:
Half of tiles should be at lowest (0..25%) heights
Redistribute heights to have more tiles at highest (75%..100%) range
As shown in #8891 (comment), this appears to drag down the peaks and make the entire map flatter.
Leaving alone subarctic for now, I don't see a need for separate subtropic rules to flatten maps. Players can just choose a flatter terrain type.
Generating a map with these settings:

Current subtropic generation:

Proposed subtropic generation:

Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.