Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Don't use special map gen for tropic #9634

Closed
wants to merge 1 commit into from

Conversation

2TallTyler
Copy link
Member

Motivation / Problem

Subtropic maps use different map generation than other climates (so does subarctic, but that's a different story) which makes it impossible to get mountainous terrain from generated maps. This limits the types of games which can be played, even as #8891 makes it possible to have all-rainforest maps. Want a hilly rainforest? Your only option is to use a heightmap.

Eliminating the special subtropic rules has been proposed before in #7340 and an associated forum topic, but was closed by the stale bot. Now that landscape generation has been simplified in #8891, I think it's worth revisiting.

Description

TGP uses separate rules for subtropic and subarctic:

  • Subtropic: Half of tiles should be at lowest (0..25%) heights
  • Subarctic: Redistribute heights to have more tiles at highest (75%..100%) range

As shown in #8891 (comment), this appears to drag down the peaks and make the entire map flatter.

Leaving alone subarctic for now, I don't see a need for separate subtropic rules to flatten maps. Players can just choose a flatter terrain type.

Generating a map with these settings:
settings

Current subtropic generation:
tropic_current

Proposed subtropic generation:
tropic_new

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@TrueBrain
Copy link
Member

TrueBrain commented Oct 20, 2021

This feels like a very cheap solution to a bigger problem, at the cost of anyone that likes the tropic mapgen :) I am not a fan of this change.

I think, and we (other developers) have been talking about this for a while now, it makes much more sense to change the approach of our "new game" window. Offer a few solid presets, and a big "advanced" button that allows you to turn every nob we can find in any way you like. One of those can be if a percentage of the map should be some type, like desert, water, snow, ... That brings in much more variation, and people can truly experiment with different forms of map generation. It even allows us to add more of these things in there, for people to find their niche.
And of course we should allow to share those presets via BaNaNaS.

But removing it outright .. that sounds like a step backwards, not forwards.

@2TallTyler
Copy link
Member Author

I'm totally on-board with new map generation presets and tools. And I don't want to eliminate the ability of a player to generate the map they want — I'm getting plenty of hate for my signal GUI PR right now. :)

But in the meantime, a subtropic Alpinist map looks like a temperate Hilly map to me. Changing the terrain type seems like a better way to choose the terrain type, rather than having special hidden rules which does something different than I expect. This disconnect between my choices in the New Map menu and what actually generates are what frustrates me. In any case, with or without the proposed new map generation presents/tools, I would like to see these hidden rules eliminated so that what I select is what gets generated.

@TrueBrain
Copy link
Member

It was never the idea that climates render their heightmap the same. Diversity was what the idea was with those climates. Basically, it is climates++. And I can understand that you struggle with that. But the fact still remains that your solution is the cheapest of all :D (sorry, I don't mean this in a bad way ofc).

@2TallTyler
Copy link
Member Author

After some discussion on Discord, let's wait for the new map generation tools to do this.

@2TallTyler 2TallTyler closed this Oct 20, 2021
@frosch123
Copy link
Member

I don't see the point in removing the tropic-special while keeping the arctic-special.
Both arctic and tropic shift the distribution of low, medium and high altitudes.

So to allow more map options, I guess you want some "elevation gamma" setting:

  • Climate-specific (default)
  • Prefer low lands
  • Normal
  • Prefer high lands

No idea whether "gamma" is a good term, probably not, but image processing uses some similar stuff to adjust brightness/contrast/gamma.

@TrueBrain
Copy link
Member

I like your suggestion @frosch123 ; and I guess we can do with yet-another-map-generation-setting :P And it fits a lot more with any future plans. Sounds like a nice compromise between the two, not @2TallTyler ? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants