Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Some gamescripts appear to be broken after loading 1.11.2 saves #9626

Closed
ldpl opened this issue Oct 19, 2021 · 2 comments
Closed

[Bug]: Some gamescripts appear to be broken after loading 1.11.2 saves #9626

ldpl opened this issue Oct 19, 2021 · 2 comments

Comments

@ldpl
Copy link
Contributor

ldpl commented Oct 19, 2021

Version of OpenTTD

12.0

Expected result

Scripts continue to work the way they did in 1.11.2

Actual result

Scripts don't function in the way they were supposed to after loading saves made in 1.11.2 version. The same scripts work fine for games started in 12.0 version. Namely in City Controller towns that weren't growing in 1.11.2 can't be made to grow even if required cargo is supplied:
Screenshot from 2021-10-18 15-22-27

I've only verified it for City Controller but there is a similar report for Simpleton CB as well (first comment):
https://steamcommunity.com/app/1536610/eventcomments/5358712989068088189/

Steps to reproduce

  1. Load
    city-controller-12-0-test.zip
  2. Compare how Radingham and Ladingstone Bay grow in 1.11.2 and 12.0

Resaving in 12.0 doesn't help
@nielsmh
Copy link
Contributor

nielsmh commented Oct 19, 2021

Could this be some cargo monitors that don't get restored properly?

@glx22
Copy link
Contributor

glx22 commented Oct 19, 2021 •
edited

Really weird, just checking script debug window is interesting.
In 12.0-beta2 or 12.0 it continuously prints some message.
In 1.11.2 it prints startup messages, and nothing more until unpaused.
In nightly (steam or local debug build), it's the same as 12.0.
In nightly (local debug build), it's like 1.11.2 in script debug, but script crashes on december 2nd.

glx22 added a commit to glx22/OpenTTD that referenced this issue Oct 19, 2021
@glx22
Fix OpenTTD#9626, ddafc0d: Incorrect loading of script saved data
eb9e6ec
@glx22 glx22 closed this as completed in eed49d7 Oct 20, 2021
TrueBrain pushed a commit to TrueBrain/OpenTTD that referenced this issue Oct 23, 2021
@glx22 @TrueBrain
Fix OpenTTD#9626, ddafc0d: Incorrect loading of script saved data (Op…
4a8a1b7 
…enTTD#9629)
TrueBrain pushed a commit that referenced this issue Oct 23, 2021
@glx22 @TrueBrain
Fix #9626, ddafc0d: Incorrect loading of script saved data (#9629)
a652ea2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ldpl @nielsmh @glx22