Proactively update descendant cull rects when needed #28800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 3, 2021
When a PaintLayer updates cull rect and the cull rect is expanded and is different from the old one, descendants should proactively update cull rects (i.e. avoid the CullRect::ChangedEnough logic). See crbug.com/1201004#c9 for more details. Bug: 1201004 Change-Id: Iad28fd2740ea0022ab43b22973de6fe664c6e10a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2868769 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#879189}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2868769
branch
from
16600aa
to
38853ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a PaintLayer updates cull rect and the cull rect is expanded and
is different from the old one, descendants should proactively update
cull rects (i.e. avoid the CullRect::ChangedEnough logic).
See crbug.com/1201004#c9 for more details.
Bug: 1201004
Change-Id: Iad28fd2740ea0022ab43b22973de6fe664c6e10a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2868769
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#879189}