Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #9186: Fix incorrect bounding box height causing station sprite glitch. #9187

Merged
merged 1 commit into from May 12, 2021
Merged

Fix #9186: Fix incorrect bounding box height causing station sprite glitch. #9187

merged 1 commit into from May 12, 2021

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented May 3, 2021

Motivation / Problem

#9186

Description

This is fixed by increasing the height of small station building bounding box to cover the building rather than just the platform.

Limitations

As noted by @JGRennison this may affect NewGRF stations, although I'm not sure it would do anything bad.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@PeterN
Fix OpenTTD#9186: Fix incorrect bounding box height causing station s…
527de2d 
…prite glitch.

Increased height of small station building bounding box to cover the build rather than just the platform.
@LordAro LordAro requested a review from frosch123 May 8, 2021 10:06
@PeterN
Copy link
Member Author

PeterN commented May 8, 2021

I tested various heights, the minimum that works in this case is 9, as it needs to be higher than the start of the bounding box on the tile behind for the sprite sorter to consider them overlapping.

frosch123
frosch123 approved these changes May 8, 2021
View reviewed changes
Copy link
Member

@frosch123 frosch123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no BB overlap with catenary, so this should be fine.

@LordAro LordAro added the backport requested This PR should be backport to current release (RC / stable) label May 8, 2021
@PeterN PeterN merged commit ba193f2 into OpenTTD:master May 12, 2021
@PeterN PeterN deleted the fix-9186 branch May 12, 2021 20:35
@TrueBrain TrueBrain removed the backport requested This PR should be backport to current release (RC / stable) label Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frosch123 frosch123 frosch123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PeterN @frosch123 @TrueBrain @LordAro