Implement colorMatrix filters for CanvasFilter objects #28802
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing SVG interface has been copied exactly, even when it doesn't
make a ton of sense, for example:
ctx.filter = new CanvasFilter({colorMatrix: {type: "saturate", values: 0.5}});
Uses the key "values" instead of "value", even though it's only a single
number.
Bug: 1169216
Change-Id: I6242f1909645ee4a2f7a6258b6563b44f3eb76eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2855935
Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
Reviewed-by: Juanmi Huertas <juanmihd@chromium.org>
Reviewed-by: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#879788}