Change: reworded many of the network errors during connect/listen #9230
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
#9017 gave a review comment that the debug statements in the ListenProc is a bit wonky. As a good citizen, I don't just fix the line I touched, but I went through all of them in both
listen()
andconnect()
.Description
I did a few things:
socket()
fails, it is not really important to what you were trying tolisten()
. The fact that we cannot do a simplesocket()
really is a big issue. Only ifbind()
fails, it is worth mentioning what we were trying to binding to.Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.