D3D11 video driver #9126
D3D11 video driver #9126
Conversation
|
I haven't tried it, but two general comments after a short look through the diff: A driver error on init should gracefully fall back to another driver, which means all those Also, the D3DCompiler DLL exists in various versions among OS versions and stuff. Official MS recommendations is the pre-compile shaders with |
Milek7
force-pushed
the
d3d11
branch
4 times, most recently
from
c6d862d to
862cc0c
Compare
I removed all throws, though I don't think they mattered much as all were after context creation (with proper feature level) so failures weren't expected.
I'm not sure about adding build-time dependency on fxc, is it available eg. on MinGW builds? I implemented exclusive fullscreen, but on purpose it is not allowed to change system resolution. It can be changed by adding DXGI_SWAP_CHAIN_FLAG_ALLOW_MODE_SWITCH to swapchain creation flags, but I'm not sure if this is desired. (note that recent Windows versions might transform it into fullwindow, so it won't be true exclusive fullscreen anyway.) |
Milek7
force-pushed
the
d3d11
branch
8 times, most recently
from
53f1cf3 to
accd0a6
Compare
|
Now two years later, sadly, no developer has picked this up. For me myself this is simply because I always think about maintainability of things we add. As OpenTTD always has low resources (in terms of people helping out), adding another driver for which we need to build up knowledge and understanding, is just a lot. For OpenGL alone we saw it was a pretty steep learning curve. I think D3D will be a less steep, but still a learning curve, and I am not able to add that to the load we already have. As such, I am going to close this PR. Not because it is a bad idea or that the PR is wrong, but simply because we cannot maintain this functionality long-term, and our OpenGL driver seems to be delivering what we were expecting at the moment, for most of the players. If any developer disagrees, please do reopen, but also please take a proactive stance and make it happen :) For the author: sorry, but nevertheless, tnx for your work on this. And sorry it took 2 years for a reply. |
Motivation / Problem
OpenGL experience on Windows might be subpar, fresh Windows installations might not have OpenGL drivers installed, etc.
Description
Mostly port of the OpenGL driver.
Limitations
Feature level 10_0 required. Might be possible to get lower with slightly more code.
Fullscreen not yet implemented.Generally DXGI model doesn't play too well with existing code.
What win32 does currently, recreating the window for each mode switch is completely unnecessary, in DXGI we can resize/switch modes without recreating window or even swapchain. However to do that requires rework of win32 base driver window creation code.Moreover, we might want to ditch exclusive fullscreen mode entirely and switch to borderless fullscreen windows. On modern compositors exclusive fullscreen have no benefitsExclusive fullscreen is implemented, but on purpose it is not allowed to change system resolution. It can be changed by adding
DXGI_SWAP_CHAIN_FLAG_ALLOW_MODE_SWITCHto swapchain creation flags, but I'm not sure if this is desired.I had to align staging texture width to 128 pixels, otherwise pitch gets screwed, I have no idea why.Fixed.I didn't implement sprite cursor drawing.
Might not be that necessary after all, as during development of this I found bug that likely caused most of the OpenGL crashes (fixed in Fix: [OpenGL] Main loop expects to start with the video buffer unmapped. #9100)
Codestyle might be off.