Change: Follow redirect convention for login also for developer flow #88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially, to fix developer login flow I edited the client to support the different authentication flow offered by vanilla bananas-api, in short, when using github, the flow is:
While using developer flow, it is:
My initial fix in bananas-frontend-cli detected a 200 response with html content and then showed the URL that was originally requested in the CLI for copy-pasting.
This PR changes the developer flow on the bananas-api side to:
The original logon form is now hosted on the /user/developer url.
This allows an almost unmodified client to connect to the API. Unfortunately, in the client, the audience is hardcoded so some changes will still be required. Expect a new client PR to arrive soon :)