Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Query windows may be partially drawn initially. #9184

Merged
merged 1 commit into from May 3, 2021
Merged

Fix: Query windows may be partially drawn initially. #9184

merged 1 commit into from May 3, 2021

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented May 3, 2021

Motivation / Problem

Query window is not marked dirty after being moved on init. It is then marked dirty once the white border flash is completed.

Description

This is resolved by calling SetDirty() after repositioning the window.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

rubidium42
rubidium42 reviewed May 3, 2021
View reviewed changes
src/misc_gui.cpp Outdated Show resolved Hide resolved
@LordAro LordAro added the backport requested This PR should be backport to current release (RC / stable) label May 3, 2021
@PeterN
Fix: Query windows may be partially drawn initially.
4cfb5c9 
Query window was not marked dirty after being moved on init. It was then marked dirty once the white border flash completed.
@LordAro LordAro merged commit 08781d9 into OpenTTD:master May 3, 2021
@PeterN PeterN deleted the fix-query-popup branch May 3, 2021 15:41
LordAro pushed a commit to LordAro/OpenTTD that referenced this pull request May 3, 2021
@PeterN @LordAro
Fix: Query windows may be partially drawn initially. (OpenTTD#9184)
a2baf27 
Query window was not marked dirty after being moved on init. It was then marked dirty once the white border flash completed.
LordAro pushed a commit that referenced this pull request May 3, 2021
@PeterN @LordAro
Fix: Query windows may be partially drawn initially. (#9184)
9aa335a 
Query window was not marked dirty after being moved on init. It was then marked dirty once the white border flash completed.
@LordAro LordAro added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubidium42 rubidium42 rubidium42 approved these changes

Assignees
No one assigned
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PeterN @rubidium42 @LordAro