New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update conformance-checkers/ tests in update-built-tests.sh #28832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running the scripts, one file is added, but everything else is in sync. build-svg-tests.py isn't used according to @sideshowbarker: #28812 (comment) Preparing for #28812.
zcorpan
approved these changes
May 5, 2021
sideshowbarker
approved these changes
May 5, 2021
foolip
added a commit
that referenced
this pull request
May 5, 2021
Also ensure update-built-tests.sh is run when conformance-checkers/ is updated, missed in #28832.
foolip
added a commit
that referenced
this pull request
May 5, 2021
Because dicts are ordered in Python 3, the order of the tests generated by url.py change. It was confirmed that exactly the same set of lines have been added and removed, with this command: ```sh diff <(git diff | grep '^+[^+]' | cut -c 2- | sort) <(git diff | grep '^-[^-]' | cut -c 2- | sort) ``` Also ensure update-built-tests.sh is run when conformance-checkers/ is updated, missed in #28832.
foolip
added a commit
that referenced
this pull request
May 5, 2021
Because dicts are ordered in Python 3, the order of the tests generated by url.py change. It was confirmed that exactly the same set of lines have been added and removed, with this command: ```sh diff <(git diff | grep '^+[^+]' | cut -c 2- | sort) <(git diff | grep '^-[^-]' | cut -c 2- | sort) ``` Also ensure update-built-tests.sh is run when conformance-checkers/ is updated, missed in #28832.
foolip
added a commit
that referenced
this pull request
May 5, 2021
Because dicts are ordered in Python 3, the order of the tests generated by url.py change. It was confirmed that exactly the same set of lines have been added and removed, with this command: ```sh diff <(git diff | grep '^+[^+]' | cut -c 2- | sort) <(git diff | grep '^-[^-]' | cut -c 2- | sort) ``` Also ensure update-built-tests.sh is run when conformance-checkers/ is updated, missed in #28832.
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
May 8, 2021
…/*.py, a=testonly Automatic update from web-platform-tests [py3] convert conformance-checkers/tools/*.py (#28812) Because dicts are ordered in Python 3, the order of the tests generated by url.py change. It was confirmed that exactly the same set of lines have been added and removed, with this command: ```sh diff <(git diff | grep '^+[^+]' | cut -c 2- | sort) <(git diff | grep '^-[^-]' | cut -c 2- | sort) ``` Also ensure update-built-tests.sh is run when conformance-checkers/ is updated, missed in web-platform-tests/wpt#28832. -- wpt-commits: 2bc4fa60f599c2e2903cdbc07fec6de4e7d781bc wpt-pr: 28812
sideshowbarker
pushed a commit
to validator/tests
that referenced
this pull request
Jun 16, 2021
Because dicts are ordered in Python 3, the order of the tests generated by url.py change. It was confirmed that exactly the same set of lines have been added and removed, with this command: ```sh diff <(git diff | grep '^+[^+]' | cut -c 2- | sort) <(git diff | grep '^-[^-]' | cut -c 2- | sort) ``` Also ensure update-built-tests.sh is run when conformance-checkers/ is updated, missed in web-platform-tests/wpt#28832.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the scripts, one file is added, but everything else is in sync.
build-svg-tests.py isn't used according to @sideshowbarker:
#28812 (comment)
Preparing for #28812.