Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update conformance-checkers/ tests in update-built-tests.sh #28832

Merged
merged 1 commit into from May 5, 2021

Conversation

foolip
Copy link
Member

@foolip foolip commented May 5, 2021

Running the scripts, one file is added, but everything else is in sync.

build-svg-tests.py isn't used according to @sideshowbarker:
#28812 (comment)

Preparing for #28812.

Running the scripts, one file is added, but everything else is in sync.

build-svg-tests.py isn't used according to @sideshowbarker:
#28812 (comment)

Preparing for #28812.
@sideshowbarker sideshowbarker merged commit 59052ab into master May 5, 2021
@sideshowbarker sideshowbarker deleted the foolip/conformance-checkers-build branch May 5, 2021 10:51
foolip added a commit that referenced this pull request May 5, 2021
Also ensure update-built-tests.sh is run when conformance-checkers/ is
updated, missed in #28832.
foolip added a commit that referenced this pull request May 5, 2021
Because dicts are ordered in Python 3, the order of the tests generated
by url.py change. It was confirmed that exactly the same set of lines
have been added and removed, with this command:
```sh
diff <(git diff | grep '^+[^+]' | cut -c 2- | sort) <(git diff | grep '^-[^-]' | cut -c 2- | sort)
```

Also ensure update-built-tests.sh is run when conformance-checkers/ is
updated, missed in #28832.
foolip added a commit that referenced this pull request May 5, 2021
Because dicts are ordered in Python 3, the order of the tests generated
by url.py change. It was confirmed that exactly the same set of lines
have been added and removed, with this command:
```sh
diff <(git diff | grep '^+[^+]' | cut -c 2- | sort) <(git diff | grep '^-[^-]' | cut -c 2- | sort)
```

Also ensure update-built-tests.sh is run when conformance-checkers/ is
updated, missed in #28832.
foolip added a commit that referenced this pull request May 5, 2021
Because dicts are ordered in Python 3, the order of the tests generated
by url.py change. It was confirmed that exactly the same set of lines
have been added and removed, with this command:
```sh
diff <(git diff | grep '^+[^+]' | cut -c 2- | sort) <(git diff | grep '^-[^-]' | cut -c 2- | sort)
```

Also ensure update-built-tests.sh is run when conformance-checkers/ is
updated, missed in #28832.
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request May 8, 2021
…/*.py, a=testonly

Automatic update from web-platform-tests
[py3] convert conformance-checkers/tools/*.py (#28812)

Because dicts are ordered in Python 3, the order of the tests generated
by url.py change. It was confirmed that exactly the same set of lines
have been added and removed, with this command:
```sh
diff <(git diff | grep '^+[^+]' | cut -c 2- | sort) <(git diff | grep '^-[^-]' | cut -c 2- | sort)
```

Also ensure update-built-tests.sh is run when conformance-checkers/ is
updated, missed in web-platform-tests/wpt#28832.
--

wpt-commits: 2bc4fa60f599c2e2903cdbc07fec6de4e7d781bc
wpt-pr: 28812
sideshowbarker pushed a commit to validator/tests that referenced this pull request Jun 16, 2021
Because dicts are ordered in Python 3, the order of the tests generated
by url.py change. It was confirmed that exactly the same set of lines
have been added and removed, with this command:
```sh
diff <(git diff | grep '^+[^+]' | cut -c 2- | sort) <(git diff | grep '^-[^-]' | cut -c 2- | sort)
```

Also ensure update-built-tests.sh is run when conformance-checkers/ is
updated, missed in web-platform-tests/wpt#28832.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants