Update OffscreenCanvas tests to respect [EnforceRange] idl annotation #28836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
AmeliaBR,
annevk,
domenic,
foolip,
fserb,
jdm,
jgraham,
kenrussell and
zqzhang
annevk
approved these changes
May 5, 2021
At least with the version of Chrome I have on my desktop (90.0.4430.93), this will now fail, but this matches the spec (and works in WebKit). |
I just checked Chrome experimental results, and these are indeed failing there and should pass after these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point, getImageData and OffscreenCanvas width/height properties were updated to use [EnforceRange] (I guess this happened at the same time as the same changes in canvas) - this updates the tests to respect this. There are already range-related tests for getImageData, so 2d.imageData.get.tiny can just be removed, size.attributes.idl I've updated to check that the exceptions are thrown and that setting out of range values has no effect.