Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup: [Fluidsynth] Comply better with the coding style #9193

Merged
merged 1 commit into from May 5, 2021
Merged

Cleanup: [Fluidsynth] Comply better with the coding style #9193

merged 1 commit into from May 5, 2021

Conversation

rubidium42
Copy link
Contributor

@rubidium42 rubidium42 commented May 4, 2021 •
edited

Motivation / Problem

Working on a bug in fluidsynth with respect to their 2.2.0 release I found the coding style to be off.

Description

Mostly * -> * and !<var> -> <var> == nullptr.

Limitations

None.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@rubidium42 rubidium42 merged commit a432009 into OpenTTD:master May 5, 2021
@rubidium42 rubidium42 deleted the fluidsynth_cleanup branch May 5, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordAro LordAro LordAro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rubidium42 @LordAro