Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 91b8ce07: dedicated servers could no longer create screenshots #9232

Merged
merged 1 commit into from May 12, 2021
Merged

Fix 91b8ce07: dedicated servers could no longer create screenshots #9232

merged 1 commit into from May 12, 2021

Conversation

TrueBrain
Copy link
Member

Fixes #9231.

Motivation / Problem

Reported via Discord by TELK, creating minimap screenshots on Dedicated server was no longer possible.

Description

    Although most commands are not useful on a dedicated server,
    screenshot commands should be dequeued.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@TrueBrain
Fix 91b8ce0: dedicated servers could no longer create screenshots
7b90914 
Although most commands are not useful on a dedicated server,
screenshot commands should be dequeued.
@TrueBrain TrueBrain added the backport requested This PR should be backport to current release (RC / stable) label May 10, 2021
@TrueBrain TrueBrain merged commit 56050fc into OpenTTD:master May 12, 2021
@TrueBrain TrueBrain deleted the fix-dedicated-queue branch May 12, 2021 14:31
@TrueBrain TrueBrain removed the backport requested This PR should be backport to current release (RC / stable) label Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubidium42 rubidium42 rubidium42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

screenshot minimap does not generates files in dedicated server
2 participants
@TrueBrain @rubidium42