Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force a new token chunk after a declarative shadow DOM end-tag. #28843

Merged
merged 1 commit into from May 5, 2021

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented May 5, 2021

This ensures that that a DSD root is always at the end of
a token chunk. This is important because the parser can
only yield or pause at token chunk boundaries. Pausing
may be forced by a declarative Shadow DOM shadow root, if it
includes a stylesheet, which blocks the HTML parser.

Bug: 904966
Change-Id: Icb170b7dd15910661dd3245f6cb277d13eec0ad7
Fixed: 1203645
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2873107
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#879468}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

This ensures that that a DSD root is always at the end of
a token chunk. This is important because the parser can
only yield or pause at token chunk boundaries. Pausing
may be forced by a declarative Shadow DOM shadow root, if it
includes a stylesheet, which blocks the HTML parser.

Bug: 904966
Change-Id: Icb170b7dd15910661dd3245f6cb277d13eec0ad7
Fixed: 1203645
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2873107
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#879468}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants