Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't update style on new focused element if it isn't in the same doc #28842

Merged
merged 1 commit into from May 6, 2021

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented May 5, 2021

This fixes a DCHECK when an iframe is moved out of the active document
from within the synchronous onblur event.

Fixed: 1204223
Change-Id: Ifda36722099554d327998b4cfd27e35aa379651c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2873191
Auto-Submit: Mason Freed <masonf@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#879742}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot changed the title Don't update style on new focused element if it isn't in active doc Don't update style on new focused element if it isn't in the same doc May 5, 2021
This fixes a DCHECK when an iframe is moved out of the active document
from within the synchronous onblur event.

Fixed: 1204223
Change-Id: Ifda36722099554d327998b4cfd27e35aa379651c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2873191
Auto-Submit: Mason Freed <masonf@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#879742}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants