Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix d4f0b6f4: [CMake] CMAKE_PROJECT_VERSION_XXX are not in CMake 3.9 #9154

Merged
merged 1 commit into from May 1, 2021

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented Apr 30, 2021

Closes #9151
Fixes #9156

Motivation / Problem

As said in #9151, CMAKE_PROJECT_VERSION_XXX variables are introduced in CMake 3.12, and we actually set minimum CMake version to 3.9.

Description

Don't use variables not available in CMake 3.9 and use PROJECT_VERSION_XXX variables (available since CMake 3.0).

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@LordAro LordAro added the backport requested This PR should be backport to current release (RC / stable) label May 1, 2021
@LordAro LordAro merged commit 2985277 into OpenTTD:master May 1, 2021
LordAro pushed a commit to LordAro/OpenTTD that referenced this pull request May 1, 2021
LordAro pushed a commit to LordAro/OpenTTD that referenced this pull request May 1, 2021
@glx22 glx22 deleted the cmake_version branch May 1, 2021 10:40
LordAro pushed a commit to LordAro/OpenTTD that referenced this pull request May 2, 2021
LordAro pushed a commit to LordAro/OpenTTD that referenced this pull request May 2, 2021
@LordAro LordAro added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

d4f0b6f requires cmake 3.12
2 participants