Codechange: Scale sprite font size once. #9158
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Calling GetHeight() on a sprite font calls ScaleFontTrad() every time. This cascades back to all GetCharacterHeight(FS_xxx) and all FONT_HEIGHT_xxx calls.
Scaling is not expensive, but it does not change either -- the cache is reset if the zoom level is changed. This call is also a virtual method call.
Description
The change sets the scaled font height once on init instead of every call to GetHeight(). This also avoids the need for GetHeight() to be a virtual method call.
Also included slightly randomly is a clean up to remove a direct access to the _default_font_height array in the FreeTypeFontCache.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.