Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #9152, #9153: screenshot command showed error messages when successful #9159

Merged
merged 1 commit into from May 1, 2021
Merged

Fix #9152, #9153: screenshot command showed error messages when successful #9159

merged 1 commit into from May 1, 2021

Conversation

rubidium42
Copy link
Contributor

@rubidium42 rubidium42 commented May 1, 2021 •
edited

Closes #9152
Closes #9153

Motivation / Problem

See #9152, #9153

Description

Change WL_CRITICAL to WL_WARNING for the ShowErrorMessage about the successful saving of the heightmap.

Limitations

Conceptually WL_INFO should have been used as well as for the screenshot, but that removes the feedback to the console which might be considered an even bigger regression.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@LordAro LordAro added the backport requested This PR should be backport to current release (RC / stable) label May 1, 2021
@TrueBrain
Copy link
Member

You mention 'see', but does it solve both?

@rubidium42
Copy link
Contributor Author

rubidium42 commented May 1, 2021 •
edited

You mention 'see', but does it solve both?

Yeah. Today I learned I should add Closes #xyz too. But yes, it fixes both.

@rubidium42 rubidium42 merged commit 40528db into OpenTTD:master May 1, 2021
@rubidium42 rubidium42 deleted the screenshot_error branch May 1, 2021 09:54
@LordAro LordAro added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordAro LordAro LordAro approved these changes

Assignees
No one assigned
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Milestone
No milestone
3 participants
@rubidium42 @TrueBrain @LordAro