Cleanup: Remove old FiosList helper methods. #9139
Merged
+30
−117
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
FiosList class is a wrapper around std::vector with some compatibility methods added to support the old SmallVector-style callers. This is legacy and not necessary.
Description
This change removes the crufty helpers, makes FiosList directly inherit of std::vector, and use the native std::vector methods and range iteratoers.
Limitations
There is one section that should be a range iterator, but it seems not to work via "this".Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.