Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash if agilent driver is used on RS scope #433

Open
fsedano opened this issue Apr 28, 2021 · 2 comments
Open

Crash if agilent driver is used on RS scope #433

fsedano opened this issue Apr 28, 2021 · 2 comments
Labels
bug Something isn't working driver Hardware drivers
Milestone
v0.2

Comments

@fsedano
Copy link
Contributor

fsedano commented Apr 28, 2021

Used wrong driver by mistake (used agilent on an RS scope), got a crash. Probably worth doing some sanitization and fail more gracefully.

fsedano@fsedano-NUC8i5BEH:~/scopehal-apps/build/src/glscopeclient$ ./glscopeclient --debug m:agilent:lan:192.168.30.139
Warning: glscopeclient works best with the OMP_WAIT_POLICY environment variable set to PASSIVE
Detecting CPU features...
    * AVX2
    
OpenCL support: not present at compile time. GPU acceleration disabled.

Connecting to SCPI oscilloscope at 192.168.30.139:5025
terminate called after throwing an instance of 'std::out_of_range'
  what():  basic_string::substr: __pos (which is 18446744073709551615) > this->size() (which is 2)
Aborted (core dumped)
fsedano@fsedano-NUC8i5BEH:~/scopehal-apps/build/src/glscopeclient$
@azonenberg
Copy link
Collaborator

Transferring this to scopehal as it's a driver issue not a UI problem.

@azonenberg azonenberg transferred this issue from ngscopeclient/scopehal-apps Apr 28, 2021
@azonenberg azonenberg added bug Something isn't working driver Hardware drivers labels Apr 28, 2021
@azonenberg
Copy link
Collaborator

This is probably a more general issue, most drivers should sanity check the *IDN? and make sure that they're being invoked on a compatible instrument.

@azonenberg azonenberg added this to the v0.1 milestone Apr 28, 2021
@azonenberg azonenberg modified the milestones: v0.1, v0.2 Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working driver Hardware drivers
Projects
None yet
Milestone
v0.2
Development

No branches or pull requests
2 participants
@azonenberg @fsedano