Properly raise SyntaxError for various mis-nested If/Elif/Else statements #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitequark
approved these changes
May 11, 2021
Codecov Report
@@ Coverage Diff @@
## master #610 +/- ##
=======================================
Coverage 81.50% 81.50%
=======================================
Files 49 49
Lines 6461 6461
Branches 1287 1287
=======================================
Hits 5266 5266
Misses 1008 1008
Partials 187 187
Continue to review full report at Codecov.
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch generalizes the fixes to #500 to correctly raise
SyntaxErrorinstead of silently doing the wrong thing for the statementsElifinsideIf,ElseinsideIf,ElifinsideElif, andElseinsideElse.There are also new tests for these cases. Additionally there are new tests to verify the correct SyntaxError for
CaseinsideCase,Stateoutside ofFSM, andStateinsideState(though their behavior was already correct and was not changed).