Expose direct socket APIs via [DirectSocketEnabled]. #28861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 6, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2874890
branch
5 times, most recently
from
c16cd6c
to
def869d
Compare
This patch introduces a new placeholder IDL extended attribute for the set of restrictions which might enable us to safely expose direct sockets, as well as a set of other APIs that have similar outside-the-web threat models. It then applies that IDL extended attribute to the existing direct socket IDL files. For the moment, this imposes two requirements on Direct Sockets: 1. Opting-into COI via COOP/COEP. 2. Toggling the kDirectSockets CLI flag. I expect these requirements to shift in the future, but this is a reasonable place to start. Patch 5/5: 1. https://chromium-review.googlesource.com/c/chromium/src/+/2871670 2. https://chromium-review.googlesource.com/c/chromium/src/+/2874306 3. https://chromium-review.googlesource.com/c/chromium/src/+/2874288 4. This patch. 5. https://chromium-review.googlesource.com/c/chromium/src/+/2875217 Note that this CL removes the Direct Socket interfaces from the `webexposed` test suite. That's a little too complicated to fix in this CL, but I aim to fix it in https://crbug.com/1206656. Bug: 1206150 Change-Id: I519e1c5d164c43f5870c45823d08063f4a3af682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2874890 Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#880498}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2874890
branch
from
def869d
to
87ac186
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces a new placeholder IDL extended attribute for the
set of restrictions which might enable us to safely expose direct
sockets, as well as a set of other APIs that have similar
outside-the-web threat models. It then applies that IDL extended
attribute to the existing direct socket IDL files.
For the moment, this imposes two requirements on Direct Sockets:
I expect these requirements to shift in the future, but this is a
reasonable place to start.
Patch 5/5:
Note that this CL removes the Direct Socket interfaces from the
webexposedtest suite. That's a little too complicated to fix inthis CL, but I aim to fix it in https://crbug.com/1206656.
Bug: 1206150
Change-Id: I519e1c5d164c43f5870c45823d08063f4a3af682
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2874890
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#880498}