Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add #ifdef guards to disable all AVX optimizations on non-x86 platforms #455

Closed
azonenberg opened this issue May 6, 2021 · 0 comments · Fixed by #675
Closed

Add #ifdef guards to disable all AVX optimizations on non-x86 platforms #455

azonenberg opened this issue May 6, 2021 · 0 comments · Fixed by #675
Assignees
@lainy
Labels
portability Things that break on some OS
Milestone
Apple Silicon sup...

Comments

@azonenberg
Copy link
Collaborator

Many drivers and filters include AVX intrinsic optimizations as well as a generic C++ implementation.

These optimized implementations are gated by runtime cpuid checks to ensure they are only used on supported platforms, but fail to even compile on non-x86 platforms. We should add preprocessor guards to ensure they are only compiled on x86.
@azonenberg azonenberg added the portability Things that break on some OS label May 6, 2021
@azonenberg azonenberg modified the milestones: v1.0, v0.2 May 6, 2021
This was referenced Sep 3, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lainy lainy

Labels
portability Things that break on some OS
Projects
None yet
Milestone
Apple Silicon support
Development

Successfully merging a pull request may close this issue.

Add #ifdefs around x86-specific code. ngscopeclient/scopehal
2 participants
@azonenberg @lainy