Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-flex][spec-rec] Write more tests containing images #7957

Closed
gregwhitworth opened this issue Oct 23, 2017 · 2 comments
Closed

[css-flex][spec-rec] Write more tests containing images #7957

gregwhitworth opened this issue Oct 23, 2017 · 2 comments
Assignees
@melanierichards @gregwhitworth
Labels
css-flexbox wg-css

Comments

@gregwhitworth
Copy link
Contributor

We need more testing around images in particular as this is one of the primary reasons the section of https://drafts.csswg.org/css-flexbox-1/#min-size-auto
@gregwhitworth gregwhitworth self-assigned this Oct 23, 2017
@gregwhitworth
Copy link
Contributor Author

Reference: https://drafts.csswg.org/css-flexbox-1/#min-size-auto

@davidsgrogan
Copy link
Member

We've added 49 test files, some having many subtests. I think we can call this done.

~/web-platform-tests/css/css-flexbox(master)$ git log --diff-filter=A --name-status --since=2018-01-01 -- *img* *image* |grep ^A\\s |wc -l
49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melanierichards melanierichards

@gregwhitworth gregwhitworth

Labels
css-flexbox wg-css
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gsnedders @melanierichards @gregwhitworth @davidsgrogan