Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

css-flexbox-row-* tests fail on Chrome in Buildbot+Taskcluster #13539

Closed
foolip opened this issue Oct 16, 2018 · 5 comments
Closed

css-flexbox-row-* tests fail on Chrome in Buildbot+Taskcluster #13539

foolip opened this issue Oct 16, 2018 · 5 comments
Labels
css-flexbox

Comments

@foolip
Copy link
Member

foolip commented Oct 16, 2018 •
edited

These four tests are failing in Chrome only, and only in wpt's infrastructure, not in Chromium:

  • /css/css-flexbox/css-flexbox-row-reverse-wrap-reverse.html
  • /css/css-flexbox/css-flexbox-row-reverse-wrap.html
  • /css/css-flexbox/css-flexbox-row-wrap-reverse.html
  • /css/css-flexbox/css-flexbox-row-wrap.html

Screenshots in #13539 (comment)

Edit: original description before screenshots were found:

This can be seen by clicking "show history" in these two views:

https://wpt.fyi/results/css/css-flexbox/css-flexbox-row-reverse-wrap-reverse.html?product=chrome[buildbot,experimental]
image

https://wpt.fyi/results/css/css-flexbox/css-flexbox-row-reverse-wrap-reverse.html?product=chrome[taskcluster,experimental]
image

Although, the pattern is the same, so that's very suspicious. @mdittmer am I seeing different things interleaved? Is this web-platform-tests/wpt.fyi#394?

Understanding the failure is really blocked on web-platform-tests/wpt.fyi#57.
@foolip foolip changed the title css-flexbox-row-reverse-wrap-reverse.html is flaky on Chrome in css-flexbox-row-reverse-wrap-reverse.html is flaky on Chrome in Buildbot+Taskcluster Oct 16, 2018
@foolip
Copy link
Member Author

foolip commented Oct 16, 2018

Context: web-platform-tests that fail only in Chrome (from wpt.fyi data) thread on blink-dev.

@foolip
Copy link
Member Author

foolip commented Oct 17, 2018

In that same thread, after the discovery of a nice accident, we can actually view the results:
https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://taskcluster-artifacts.net/cHFVBzPHR1ylzr6MpVl7_A/0/public/results/log_tbpl.log

Here's the test and ref image extracted:
image
image

I'm not sure what this means without debugging the tests. There are however four tests with this same failure mode/pattern:
/css/css-flexbox/css-flexbox-row-reverse-wrap-reverse.html
/css/css-flexbox/css-flexbox-row-reverse-wrap.html
/css/css-flexbox/css-flexbox-row-wrap-reverse.html
/css/css-flexbox/css-flexbox-row-wrap.html

The failures don't happen in Chromium. I'll update the bug description to match.

@cbiesinger if you have any ideas about what might be causing this it'd be much appreciated.

@foolip foolip changed the title css-flexbox-row-reverse-wrap-reverse.html is flaky on Chrome in Buildbot+Taskcluster css-flexbox-row-* tests fail on Chrome in Buildbot+Taskcluster Oct 17, 2018
@gsnedders
Copy link
Member

Is there any reason why these tests are using the full-width glyphs anyway? Just for the sake of deterministic character widths?

@davidsgrogan
Copy link
Member

I rewrote these to not use any text. They pass everywhere now. https://wpt.fyi/results/css/css-flexbox?label=master&label=experimental&aligned&q=css-flexbox-row

@foolip
Copy link
Member Author

foolip commented May 4, 2021

Thanks @davidsgrogan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css-flexbox
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gsnedders @foolip @davidsgrogan