Fix: lobby window doesn't close if no connection could be established #9223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubidium42
approved these changes
May 9, 2021
There was a problem hiding this comment.
##Future work
Maybe we should think about splitting network_gui.cpp into a file per Window, and add everything specific to that window like these query connecters in the file specific to that Window. Technically the connecters are no GUI code, but... they are only used for that GUI and not of any use in the dedicated server. Of course after stun/turn/etc. have been implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
In some cases it is possible that you could open the Lobby window, but the connection to the server could not be established. This leaves you in this weird state where the Lobby window is not receiving any company info, but also doesn't tell you the connection is not established.
Description
Drop out of the Lobby window if the connection could not be established.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.