New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid asking for data if not needed on RS driver #437

Merged

azonenberg merged 1 commit into ngscopeclient:master from fsedano:fix_data

Apr 30, 2021

Contributor

fsedano commented Apr 30, 2021

Sometimes scope would not reply to the HEAD query, or return 0 as length. If that's the case, querying for DATA would hang the scope.

This patch skips DATA query if HEAD response is invalid or zero.

Additionally, we were not checking if DATA was properly parsed, and we were alloc'ing based on garbage if there was a parse error.


          Avoid asking for data if not needed

6cdb09d

fsedano changed the title ~~Avoid asking for data if not needed~~ Avoid asking for data if not needed on RS driver

azonenberg merged commit abbf63c into ngscopeclient:master

fsedano deleted the fix_data branch

May 2, 2021 22:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment