Change: use TCP for everything except for master-server and initial server scan #9130
+78
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrueBrain
force-pushed
the
network-tcp-more
branch
from
33dd990 to
2e3b56b
Compare
TrueBrain
commented
Apr 28, 2021
TrueBrain
force-pushed
the
network-tcp-more
branch
from
2e3b56b to
2d82972
Compare
LordAro
changed the title
TrueBrain
force-pushed
the
network-tcp-more
branch
5 times, most recently
from
eeeac6d to
dcc45d8
Compare
rubidium42
reviewed
Apr 29, 2021
…erver scan This means that pressing Refresh button and adding servers manually now uses TCP. The master-server and initial scan are still UDP as they will be replaced by Game Coordinator; no need to change this now. If we query a server that is too old, show a proper warning to the user informing him the server is too old.
TrueBrain
force-pushed
the
network-tcp-more
branch
from
dcc45d8 to
7bd2a31
Compare
|
👍 Removing UDP will make the game easier to host using tools like ngrok, which only support TCP. At the moment I hacked my fork to allow joining servers even if there is no response to UDP pings, but that hack has a number of drawbacks. |
rubidium42
approved these changes
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
In the next step to deprecate UDP more, we now also do refresh prior to the lobby over TCP.
This is the first commit that actually breaks the network protocol. Clients using master can no longer refresh older servers. That is to say: they see the list come in from the Master Server, they see them being queried over UDP, but as soon as they manually hit refresh, it shows an error the server is too old.
Also, the last server joined and manually added servers will give similar popups.
Further commits will set out to remove the rest of UDP as the master server is being replaced by Game Coordinator, but to keep things reviewable, this is another small step!
Description
Limitations
Using the nightly can be confusing to players, as all servers do show up, but refreshing gives an error. Mind you: they can never join them anyway.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.