Add: [[nodiscard]] to std::string str_validate #9201
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
The std::string version of str_validate creates a new string, contrary to the C-string str_validate which changes the buffer that was passed. As a result, anyone mistaken in the behavior will not get the expected result. The code will compile fine, but the validation will not happen. Especially when that data is to be considered insecure, that can be a major issue.
Description
Add [[nodiscard]] to the std::string version so the compiler will complain whenever the returned cleaned/validate string is not used.
Limitations
None
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.