Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reftests take screenshot too early in Edge #6327

Closed
2 tasks
gsnedders opened this issue Jun 23, 2017 · 8 comments
Closed
2 tasks

Reftests take screenshot too early in Edge #6327

gsnedders opened this issue Jun 23, 2017 · 8 comments

Comments

@gsnedders
Copy link
Member

Similar to #5412. w3c/csswg-drafts#1088 is the issue that causes issues here. Notably, wptrunner needs to:

  • Block screenshots on fonts loading. (Unclear we can do this through JS or through WebDriver in any way given Edge doesn't support the Font Loading API.)
  • Block screenshots on background images, list item images, etc. loading. (Unclear we can do this through JS or WebDriver in any way.)

Both of these are really problems web developers would hit if they wanted to do any screenshot-based testing over WebDriver, so I'd hope there's some way to work around them!

cc/ @patrickkettner @thejohnjansen

@thejohnjansen
Copy link
Contributor

I am looking at the best solution that isn't just a hack for this. Internally we have a function that we call that tells us it's likely OK to take a screenshot. That is currently internal, though. I'm investigating making it external vs. possibly finding a better way. Currently the solutions I've found are all hacky, and we should avoid being hacky when it comes to stability jobs if possible.

@jgraham
Copy link
Contributor

jgraham commented Jun 29, 2017

Can't WebDriver wait on that to take a screenshot? I'm happy to lobby for a spec change to make it official that you are exepcted to wait for a stable state after load before taking a screenshot. Otherwise we should add another load strategy to WebDriver for this purpose.

@gsnedders
Copy link
Member Author

@jgraham See w3c/webdriver#893 wrt that.

gsnedders added a commit to gsnedders/web-platform-tests that referenced this issue Jul 14, 2017
gsnedders added a commit to gsnedders/web-platform-tests that referenced this issue Jul 14, 2017
gsnedders added a commit to gsnedders/web-platform-tests that referenced this issue Jul 14, 2017
jgraham pushed a commit that referenced this issue Jul 18, 2017
@bobholt
Copy link
Contributor

bobholt commented Oct 4, 2017

Looks like @gsnedders fixed the font issue for wpt, but the other still pending resolution of w3c/webdriver#893

@gsnedders
Copy link
Member Author

@bobholt Uh, that commit message seems totally wrong. That commit shouldn't have changed anything in Edge, given Edge doesn't support the Font Loading API (currently "Under Consideration" on the Edge platform status page).

@foolip
Copy link
Member

foolip commented Jan 24, 2018

@thejohnjansen, do you have any update on #6327 (comment), something we could use both for the Travis CI runs and for wpt.fyi?

And does anyone know how widespread this issue? https://wpt.fyi/css/css-overflow/input-scrollable-region-001.html is one reftests that's passing in Edge and it's easy to find more, so at least not all reftests are failing.

@foolip
Copy link
Member

foolip commented May 6, 2021

This is about EdgeHTML, so should we close this issue? I'm guessing nobody will even run WPT against Edge 18 again...

@thejohnjansen
Copy link
Contributor

I think it's fine to close this one out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants