Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: [Network] Use std::string for network game info #9200

Merged
merged 3 commits into from May 6, 2021

Conversation

rubidium42
Copy link
Contributor

Motivation / Problem

Simplification of string handling for the network game info, so less chance on buffer overruns.

Description

Addition of some helper functions to pass std::string to SetDParamStr and DrawString.
Replace the C-string server name and revision with a std::string variant.

Limitations

None.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@rubidium42 rubidium42 merged commit f1dfa66 into OpenTTD:master May 6, 2021
@rubidium42 rubidium42 deleted the string_game_info branch May 6, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants