Convert conformance-checkers/tools/url.py back to using strings #28873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#28812 made the script unnecessarily complicated with a mix of strings and bytes, and made it hard to tell if the written files might ever be invalid UTF-8. It turns out that the output is unchanged if one simply operates on strings all along. The change of ordering initially misled me.
sideshowbarker
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#28812 made the script
unnecessarily complicated with a mix of strings and bytes, and made it
hard to tell if the written files might ever be invalid UTF-8.
It turns out that the output is unchanged if one simply operates on
strings all along. The change of ordering initially misled me.