[css-values-3] Improve attr-px-invalid-cast.html and attr-px-invalid-fallback.html tests #28816
Conversation
|
There are still a few small issues (extraneous declarations, browsers with no support for attr() will pass attr-px-invalid-fallback.html) with the 2 tests but, now, the 2 tests have been corrected and this is what is important here. |
There was a problem hiding this comment.
Looks good to me. These tests are somewhat tricky to review, you really gotta look at the spec to confirm all the details 😆
One thing that could be done is that my email address could optionally be updated to my current one (francois.remy.dev (arobase) outlook.com), but given this is only a set of two tests that might not be the appropriate commit to do that.
Thanks for noticing the asset help mismatch.
|
François, The 8.2. Attribute References: attr() section could be improved with, say, 2 or 3 additional examples. I have created Issue 6268 on this. |
attr-px-invalid-cast.html
attr-px-invalid-fallback.html
I must first convert the line-starting tabs with 2 blank spaces so that the lint tool does not report this and so that the review of the tests can be easier.
The corrections have been explained in Issue 28765 and in Issue 28794 .