Implement <popup> focus, autofocus, delegatesfocus #28827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 4, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2869490
branch
from
61feb5a
to
41356a7
Compare
This CL implements most of the focus behavior for <popup. This includes the default focus behavior, plus the implementation of the autofocus and delegatesfocus attributes. See [1] for more context. A WPT is added here that exercised all new functionality. [1] https://open-ui.org/components/popup.research.explainer Bug: 1168738 Change-Id: I6ec607c7dc250c8edb0d8bd4245e0f21303599a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2869490 Commit-Queue: Mason Freed <masonf@chromium.org> Reviewed-by: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#879576}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2869490
branch
from
41356a7
to
9f52a53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL implements most of the focus behavior for <popup. This includes
the default focus behavior, plus the implementation of the autofocus
and delegatesfocus attributes. See [1] for more context. A WPT is
added here that exercised all new functionality.
[1] https://open-ui.org/components/popup.research.explainer
Bug: 1168738
Change-Id: I6ec607c7dc250c8edb0d8bd4245e0f21303599a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2869490
Commit-Queue: Mason Freed <masonf@chromium.org>
Reviewed-by: Ionel Popescu <iopopesc@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#879576}