Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: [Network] More std::string with less code #9192

Merged
merged 3 commits into from May 6, 2021

Conversation

rubidium42
Copy link
Contributor

Motivation / Problem

Connection string parsing was modifying the input data which I find kind of odd.

Description

So, I rewrote it to make use of std::string_view for the different parts.
For that NetworkAddress needed to accept std::string_view, so made hostname a std::string, which in it turn required NetworkGameList to be new/deleted instead of calloc/freed.

Limitations

None

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

Copy link
Member

@TrueBrain TrueBrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need someone else to look at std::from_chars, as I don't know what that is and if it is used in a proper manner :D

src/network/core/address.cpp Outdated Show resolved Hide resolved
src/network/core/address.h Outdated Show resolved Hide resolved
src/network/network_gamelist.h Outdated Show resolved Hide resolved
@rubidium42 rubidium42 force-pushed the less_string_copy branch 2 times, most recently from 9130b2c to 8d0d165 Compare May 6, 2021 11:01
frosch123
frosch123 previously approved these changes May 6, 2021
src/network/core/address.h Show resolved Hide resolved
@rubidium42 rubidium42 merged commit 3d91eee into OpenTTD:master May 6, 2021
@rubidium42 rubidium42 deleted the less_string_copy branch May 6, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants