Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not flow a flight plan segment that is before the Ephemeris t_min #2978

Merged
merged 8 commits into from
May 10, 2021

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented May 8, 2021

Request reanimation instead.

Part of #2400, take two.

Fix #2975.

max_ephemeris_steps_per_frame);
} else {
ephemeris_->RequestReanimation(starting_time);
return Status::OK;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to break all the invariants: we have a segment that has not been flowed, but we say it is OK. If we eventually hit a segment whose starting time is after t_min, we are going to try integrating that, and assuming this doesn’t crash, we will have a missing segment followed by a normal segment, which is not how anomaly works in the flight plan.
This should return an erroneous status so that the entire flight plan becomes anomalous.
This should probably also have a unit test.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, PTAL.

@eggrobin eggrobin added the LGTM label May 9, 2021
@pleroy pleroy merged commit 5f8c20c into mockingbirdnest:Grassmannian May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants