Add: [Actions] Check CI annotations to detect compile warnings #9217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
TrueBrain
reviewed
May 8, 2021
TrueBrain
reviewed
May 8, 2021
glx22
force-pushed
the
annotations
branch
2 times, most recently
from
1418eb6
to
352da8b
Compare
TrueBrain
approved these changes
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
When compilation generates warnings in a PR, they are visible in
checkstab and inlined inFiles changedtab, but they are easy to miss if not actively looked for.Description
This adds a CI job to check if there are any annotations generated by previous jobs, and "fails" CI if any is found.
And I enabled this job for PRs only.
A test PR with compile warnings is available here.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.