Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up more around base64.decodebytes() calls #28757

Merged
merged 1 commit into from May 6, 2021
Merged

Conversation

foolip
Copy link
Member

@foolip foolip commented Apr 30, 2021

Follow-up to #28747.

@foolip
Copy link
Member Author

foolip commented May 5, 2021

Care must be taken when merging this and #28789. Both change webdriver/tests/support/asserts.py, and the second to land also needs to remove the import six statement. But I don't know which will land first yet.

webdriver/tests/support/asserts.py Outdated Show resolved Hide resolved
webdriver/tests/support/image.py Outdated Show resolved Hide resolved
@foolip
Copy link
Member Author

foolip commented May 6, 2021

I'm fairly confident I didn't break the tests here:

  • Chrome – no changes
  • Firefox – looks like existing flakiness
  • Safari – looks like existing flakiness

@foolip
Copy link
Member Author

foolip commented May 6, 2021

Thanks @jgraham! Just to be sure I've rebased to trigger another run, and will check if any of the changes are consistent regressions before landing.

@foolip
Copy link
Member Author

foolip commented May 6, 2021

Alright, in the latest run Firefox had no regressions. Safari did, and here's the combination of 4 runs:
https://wpt.fyi/results/webdriver/tests?q=seq%28status%3Apass%20status%3A%21pass%20status%3Apass%20status%3A%21pass%29&run_id=5755592649998336&run_id=5760575348932608&run_id=5640824303910912&run_id=5731672098078720

With that, the only candidate regression is "AssertionError: session not created (500): Could not create a session: The Safari instance terminated while trying to pair with it." which I'm confident I didn't cause here.

@foolip foolip merged commit f81cf23 into master May 6, 2021
@foolip foolip deleted the foolip/decodebytes branch May 6, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants