Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webdriver tests should default to use the HTTPS protocol #28847

Closed
whimboo opened this issue May 5, 2021 · 3 comments · Fixed by #40910
Closed

Webdriver tests should default to use the HTTPS protocol #28847

whimboo opened this issue May 5, 2021 · 3 comments · Fixed by #40910
Labels
webdriver

Comments

@whimboo
Copy link
Contributor

whimboo commented May 5, 2021

As just noticed when trying to get a test with Cross-Origin-Opener-Policy added, the url fixture (which other fixtures like inline are based on) defaults to HTTP. That means we basically don't test anything for HTTPS right now, which is IMO a huge deficit.

Switching the default to HTTPS raises another question. How can we get a valid certificate added to the certificate store of each browser to not have to enable the acceptInsecureCerts capability? As @jgraham pointed out for Firefox it will be easy soon when his patch series from PR #28729.

But how does it look like for other browsers?

CC'ing @foolip, @burg, @JohnChen0, @bwalderman.
@foolip
Copy link
Member

foolip commented May 5, 2021

The problem of a trusted certificate is already solved since stuff like https://web-platform.test:8443 is used while running lots of testharness.is tests.

I have almost no experience with the WebDriver tests in WPT so I don't know if that setup is easy to reuse, or perhaps if it's already in use.

@whimboo
Copy link
Contributor Author

whimboo commented May 5, 2021

That is great to know! I will have a look how easy it is to just use this port. As it looks like we shouldn't just use the first available port there:

port = server_config["ports"][protocol][0]

Do we have a list documented, which ports can be used for what purpose?

@whimboo
Copy link
Contributor Author

whimboo commented Jun 15, 2023

This topic has been discussed yesterday in the monthly meeting of the Browser Testing and Tools working group: https://www.w3.org/2023/06/14-webdriver-minutes.html#t08

github: web-platform-tests/wpt#28847
jgraham_ (IRC): WPT in general uses http as the default. THis doesn't match the web anymore
… this is not going to impact the webdriver so much
… so we should move that to be more like the web
automatedtester: as long as we still make sure that we test misconfigured servers then I don't see this being an issue
jgraham: that will be fine

@whimboo whimboo mentioned this issue Jul 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
webdriver
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Webdriver tests should default to use the HTTPS protocol whimboo/wpt
2 participants
@whimboo @foolip