Populate pointerId, pointerType for contextmenu event #28844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 5, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2874026
branch
5 times, most recently
from
31d75ba
to
0a96fdf
Compare
For contextmenu as a pointer event pointerId and pointerType were not populated. In this CL we are populating pointerId/pointerType for contextmenu coming from touch and mouse. For touch we use a similar approach to crrev.com/c/2800231 for populating pointerId,pointerType for clicks generated in GestureManager::HandleGestureTap. The main change will be in EventHandler::SendContextMenuEvent where we'll be passing id and pointer type to the call to MouseEventManager::DispatchMouseEvent. This in turn will populate pointerId and pointerType correctly when the contextmenu PointerEvent is created. Bug: 1150442,1150441 TEST: external/wpt/pointerevents/pointerevent_contextmenu_is_a_pointerevent.html Change-Id: If2408d9cf0d5f00b08efcf2236ff7933472972ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2874026 Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#881145}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2874026
branch
from
0a96fdf
to
f18df9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For contextmenu as a pointer event pointerId and pointerType
were not populated.
In this CL we are populating pointerId/pointerType for contextmenu
coming from touch and mouse.
For touch we use a similar approach to crrev.com/c/2800231
for populating pointerId,pointerType for clicks generated in
GestureManager::HandleGestureTap.
The main change will be in EventHandler::SendContextMenuEvent
where we'll be passing id and pointer type to the call to
MouseEventManager::DispatchMouseEvent. This in turn will
populate pointerId and pointerType correctly when the contextmenu
PointerEvent is created.
Bug: 1150442,1150441
TEST: external/wpt/pointerevents/pointerevent_contextmenu_is_a_pointerevent.html
Change-Id: If2408d9cf0d5f00b08efcf2236ff7933472972ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2874026
Commit-Queue: Liviu Tinta <liviutinta@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#881145}