[Gecko Bug 1709232] Make PerformanceObserver.supportedEntryTypes respects dom.enable_event_timing #28845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t_timing PerformanceObserver.supportedEntryTypes doesn't check whether PerformanceEventTiming is enabled or not, so it'll falsely claims PerformanceEventTiming is supported even if the pref is disabled. This patch fixes that by adding a guard to it. Differential Revision: https://phabricator.services.mozilla.com/D114250 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1709232 gecko-commit: 809f11778c3990c3eab0d284b298620d0121ea77 gecko-reviewers: emilio
wpt-pr-bot
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PerformanceObserver.supportedEntryTypes doesn't check whether
PerformanceEventTiming is enabled or not, so it'll falsely claims
PerformanceEventTiming is supported even if the pref is disabled.
This patch fixes that by adding a guard to it.
Differential Revision: https://phabricator.services.mozilla.com/D114250
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1709232
gecko-commit: 809f11778c3990c3eab0d284b298620d0121ea77
gecko-reviewers: emilio